Allow APIResponse on resource class #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APIResponse annotations on the method override APIResponse annotations on the resource class with the same response code.
|
Reading over this again, should we allow Adding it to the class seems more natural, I assume it was only applied to the method because previously the annotation only targeted methods. |
I think that makes sense. |
|
Updated to test for APIResponse on an ExceptionMapper class. |
Allow the APIResponse annotation to be used on an exception mapper class as well as the toResponse method.
Azquelt
force-pushed
the
api-response-resource-class
branch
from
99427ea to
fc5ddf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APIResponseannotations on the method overrideAPIResponseannotationson the resource class with the same response code.
Fixes #417