Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issues for MP starter #499

Merged
merged 26 commits into from
Oct 17, 2024
Merged

Conversation

breakponchito
Copy link
Contributor

@breakponchito breakponchito commented Oct 10, 2024

Fixing issues to execute build tests

@breakponchito breakponchito mentioned this pull request Oct 10, 2024
@Emily-Jiang
Copy link
Member

@breakponchito there are many failures

@breakponchito
Copy link
Contributor Author

@breakponchito there are many failures

yeah checking what to do for the following error:
image

in all cases is the same issue

@breakponchito
Copy link
Contributor Author

@breakponchito there are many failures

@Emily-Jiang I already upgrade the version for the upload-artifact to use v4, please run again the validations

@breakponchito
Copy link
Contributor Author

@Emily-Jiang Could you help me to run again the tests? it seems a network problem, on my local I can't reproduce same error

@breakponchito
Copy link
Contributor Author

@Emily-Jiang please run again the validation. I'm testing to increment connect timeout and read timeout to minutes

Copy link
Member

@Emily-Jiang Emily-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We will merge this one as the test failure cannot be replicated locally. We will then deploy the starter app to Open Liberty in a separate issue #498. With that, we should be able to fix all of the test failures.

@Emily-Jiang
Copy link
Member

We discussed at today's call and agreed to merge this PR for now.

@Emily-Jiang Emily-Jiang merged commit 09ddc62 into eclipse:main Oct 17, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants