Add support to the slider to format the value #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
force-pushed
the
slider_textformat
branch
from
61d5901
to
20a3359
Compare
Currently the slider always show the raw number, but often this is not very suitable for the user e.g. if the Number represents a unit of measure or should be formated with a number format. This adds a new method NebulaSlider#setLabelFormatProvider that allows to customize the formating of the raw number.
laeubi
force-pushed
the
slider_textformat
branch
from
20a3359
to
a6fc901
Compare
|
Good job, thank you Christoph for this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the slider always show the raw number, but often this is not very suitable for the user e.g. if the Number represents a unit of measure or should be formated with a number format.
This adds a new method NebulaSlider#setLabelFormatProvider that allows to customize the formatting of the raw number.
This then maybe looks like this:
