Eliminate vm.heapBaseAddress() #5757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchopra001
requested review from
0xdaryl,
andrewcraik,
aviansie-ben,
fjeremic,
Leonardo2718,
mstoodle and
vijaysun-omr
as code owners
|
What's the reason for doing this? The commit message doesn't have a description. |
Sorry about that I've updated it now. |
This commit removes OMR::VMEnv::heapBaseAddress() as this routine always returns 0. It was introduced in the codebase early on in the codebase and has since been superseded by a shift-based solution. Hence it no longer needed. Signed-off-by: Dhruv Chopra <Dhruv.C.Chopra@ibm.com>
dchopra001
force-pushed
the
elimHeapBase
branch
from
046f5ee
to
ab1fd2e
Compare
fjeremic
suggested changes
Jan 19, 2021
- Remove changeHeapBaseConstToLoad routine - Remove translatedNode search Signed-off-by: Dhruv Chopra <Dhruv.C.Chopra@ibm.com>
fjeremic
approved these changes
Jan 21, 2021
|
@genie-omr build all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes
OMR::VMEnv::heapBaseAddress()as this routine always returns 0. It was introduced in the codebase early on in the codebase and has since been superseded by a shift-based solution. Hence this is no longer needed. See eclipse-openj9/openj9#11263 for original issue and discussion.Signed-off-by: Dhruv Chopra Dhruv.C.Chopra@ibm.com