Eliminate vm.heapBaseAddress() #11688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related OMR PR: eclipse/omr#5757 |
This commit removes J9::VMEnv::heapBaseAddress() as this routine always returns 0. It was introduced in the codebase early on in the codebase and has since been superseded by a shift-based solution. Hence it no longer needed. Signed-off-by: Dhruv Chopra <Dhruv.C.Chopra@ibm.com>
dchopra001
force-pushed
the
elimHeapBase
branch
from
755278f
to
8a4bb3a
Compare
fjeremic
reviewed
Jan 19, 2021
fjeremic
reviewed
Jan 19, 2021
- Remove translatedNode search - Move boolean definition closer to first use - Remove some dead code Signed-off-by: Dhruv Chopra <Dhruv.C.Chopra@ibm.com>
fjeremic
reviewed
Jan 21, 2021
Signed-off-by: Dhruv Chopra <Dhruv.C.Chopra@ibm.com>
Signed-off-by: Dhruv Chopra <Dhruv.C.Chopra@ibm.com>
fjeremic
approved these changes
Jan 28, 2021
|
Jenkins test sanity all jdk8,jdk11 depends eclipse/omr#5757 |
|
Jenkins test sanity s390x jdk11 depends eclipse/omr#5757 |
|
Linux s390x issues is due to #11795. Will wait for a good. Will wait for the OMR-Acceptance tonight before merging. |
|
OMR-Acceptance is broken at the moment due to some CMake issue. Waiting for a fix on that before we can merge this. |
|
eclipse-openj9/openj9-omr@openj9...master
We're in a good state right now. Going ahead with the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes
J9::VMEnv::heapBaseAddress()as this routine always returns 0. It was introduced in the codebase early on in the codebase and has since been superseded by a shift-based solution. Hence this is no longer needed. See #11263 for original issue and discussion.Fixes: #11263
Signed-off-by: Dhruv Chopra Dhruv.C.Chopra@ibm.com