AArch64: Properly find compressed refs sequence in implicit NULLCHK #12351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test sanity alinux64 jdk11 |
Akira1Saitoh
commented
Apr 7, 2021
| // iu2l | ||
| // iloadi/irdbari f <- n | ||
| // aload O <- reference | ||
| // iconst shftKonst |
There was a problem hiding this comment.
I updated the compressed sequence tree in the comment to be consistent with the current IL.
We do not have ladd anymore since heapbase has been eliminated in #11688
|
jenkins test sanity alinux64 jdk11 |
|
The previous test was aborted: |
Akira1Saitoh
force-pushed
the
aarch64FixImplicitNullCHK
branch
from
cc1ab53
to
879fc48
Compare
|
jenkins test sanity alinux64 jdk11 |
Akira1Saitoh
force-pushed
the
aarch64FixImplicitNullCHK
branch
from
879fc48
to
7d33480
Compare
`evaluateNULLCHKWithPossibleResolve` does pattern matching to find load operation in compressed references sequences, but it searches for `TR::i2l` instead of correct opcode `TR::iu2l`. Also, if it is a load operation and the reference count of the load node under the compressed refs sequence is 1, explicit NULLCHK is used even if the reference count of `TR::l2a` node is more than 2. This commit changes `evaluateNULLCHKWithPossibleResolve` to - Use opcode value of the parent of the reference node for judging whether it is a load operation instead of searching `TR::iu2l`. - Use implicit NULLCHK if `TR::l2a` node's reference count > 2. - Use recursivelyDecReferenceCount for firstChild if it is not evaluated. Signed-off-by: Akira Saitoh <saiaki@jp.ibm.com>
Akira1Saitoh
force-pushed
the
aarch64FixImplicitNullCHK
branch
from
7d33480
to
6c5727f
Compare
|
jenkins test sanity alinux64 jdk11 |
knn-k
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
evaluateNULLCHKWithPossibleResolvedoes pattern matching tofind load operation in compressed references sequences, but it searches for
TR::i2linstead of correct opcodeTR::iu2l.Also, if it is a load operation and the reference count of the load node
under the compressed refs sequence is 1, explicit NULLCHK is used
even if the reference count of
TR::l2anode is more than 2.This commit changes
evaluateNULLCHKWithPossibleResolvetowhether it is a load operation instead of searching
TR::iu2l.TR::l2anode's reference count > 2.Signed-off-by: Akira Saitoh saiaki@jp.ibm.com