Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AArch64: Properly find compressed refs sequence in implicit NULLCHK #12351

Merged

Commits on Apr 8, 2021

  1. AArch64: Properly find compressed refs sequence in implicit NULLCHK

    `evaluateNULLCHKWithPossibleResolve` does pattern matching to
    find load operation in compressed references sequences, but it searches for
    `TR::i2l` instead of correct opcode `TR::iu2l`.
    Also, if it is a load operation and the reference count of the load node
    under the compressed refs sequence is 1, explicit NULLCHK is used
    even if the reference count of `TR::l2a` node is more than 2.
    
    This commit changes `evaluateNULLCHKWithPossibleResolve` to
    - Use opcode value of the parent of the reference node for judging
       whether it is a load operation instead of searching `TR::iu2l`.
    - Use implicit NULLCHK if `TR::l2a` node's reference count > 2.
    - Use recursivelyDecReferenceCount for firstChild if it is not evaluated.
    
    Signed-off-by: Akira Saitoh <saiaki@jp.ibm.com>
    Akira Saitoh committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    6c5727f View commit details
    Browse the repository at this point in the history