Fold TR_X86ComputeCC into TreeEvaluator #6718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins copyright check |
|
@kevindean12 : could you fix up the copyright dates in the files reported by the copyright CI job please? |
-In order to make the methods of TR_X86ComputeCC extensible for downstream projects, fold the class, which only contains one static method and no data members, into TreeEvaluator
kevindean12
force-pushed
the
trcomputecc
branch
from
07d3d3d
to
efc5d94
Compare
|
@0xdaryl fixed! |
|
Jenkins build all |
0xdaryl
approved these changes
Oct 4, 2022
|
Looks like |
|
Thanks for spotting that @a7ehuo . Would you mind opening a PR with that small change and I will merge it? |
|
I'll open a PR in OpenJ9 shortly |
a7ehuo
added a commit
to a7ehuo/openj9
that referenced
this pull request
Oct 4, 2022
X86Evaluator.hpp is removed in eclipse/omr#6718 Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
|
Opened eclipse-openj9/openj9#16038 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make the methods of TR_X86ComputeCC extensible for downstream projects, fold the class, which only contains one static method and no data members, into TreeEvaluator.