Fix "substract" typo #6840
Open
Fix "substract" typo #6840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spencer-Comin
force-pushed
the
fix-substract-typo
branch
from
848f722
to
deeaab5
Compare
|
Jenkins Build zos,zlinux |
Spencer-Comin
force-pushed
the
fix-substract-typo
branch
from
deeaab5
to
29805bc
Compare
|
Jenkins Build zos,zlinux |
|
All the builds have passed. This one is good to merge. @0xdaryl Can I request to merge this one ? |
Spencer-Comin
force-pushed
the
fix-substract-typo
branch
from
29805bc
to
f92cbd1
Compare
|
Rebased due to eclipse-openj9/openj9#16431 (comment) |
Spencer-Comin
force-pushed
the
fix-substract-typo
branch
from
f92cbd1
to
549f0cb
Compare
Spencer-Comin
force-pushed
the
fix-substract-typo
branch
from
549f0cb
to
aee8488
Compare
|
@Spencer-Comin Looks like this one was missed. Can you rebase your branch so we can start tests again and merge ? |
Spencer-Comin
force-pushed
the
fix-substract-typo
branch
2 times, most recently
from
33796c9
to
c50c8ae
Compare
|
@Spencer-Comin Do we need to rebase and get this merged? |
Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
Spencer-Comin
force-pushed
the
fix-substract-typo
branch
from
c50c8ae
to
120a1a5
Compare
Spencer-Comin
requested review from
0xdaryl,
knn-k and
vijaysun-omr
as code owners
|
Rebased and added remaining instances of "substract" throughout the codebase |
|
The arm part looks good to me. |
|
jenkins build all |
|
@Spencer-Comin What is the order of this and the OpenJ9 PR to go ? Do we need coordinated merge ? |
|
@r30shah we will need coordinated merge |
|
x86 macOS failure looks like #7181 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
substract -> subtract