Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize README content #120

Closed
spoenemann opened this issue Jun 4, 2020 · 1 comment · Fixed by #122
Closed

Sanitize README content #120

spoenemann opened this issue Jun 4, 2020 · 1 comment · Fixed by #122
Assignees
@jbicker
Labels
webui Component: webui

Comments

@spoenemann
Copy link
Member

We suffer from the same problem as eclipse-theia/theia#7954 because we also use markdown-it and use its output with dangerouslySetInnerHTML. We should make sure the Markdown content is sanitized before we apply it to the DOM.
@spoenemann spoenemann added the webui Component: webui label Jun 4, 2020
@spoenemann
Copy link
Member Author

To reproduce: publish an extension with <style onload="alert(0)"> in its README.md

@jbicker jbicker self-assigned this Jun 4, 2020
jbicker added a commit that referenced this issue Jun 5, 2020
@jbicker
Added DOMPurify and sanitized readme text.
61d9a86 
Fixes #120

Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
@jbicker jbicker mentioned this issue Jun 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbicker jbicker

Labels
webui Component: webui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added DOMPurify and sanitized readme text. eclipse/openvsx
2 participants
@spoenemann @jbicker