Move login to menu content

[amvanbaren]

Makes it possible to make the webui read only as requested in #1041.
The default menu stays the same. The mobile menu is a bit different.

BEFORE	AFTER

[amvanbaren]

@kineticsquid @filiptronicek What do you think?

[kineticsquid]

I'm good with the requirement to make the webui read only. This PR looks good to me. I'd like to hear from @filiptronicek and @spoenemann.

[filiptronicek]

Changes look good, the mobile menu improvements are very appreciated.

Makes it possible to make the webui read only as requested in #1041.

Could you point me to the read-only changes in the PR? I couldn't find anything related to it.

[svor]

Hello @amvanbaren, @filiptronicek!
Thank you for looking at my request! I was working a bit on #1041 as well and it's what I have: #1041
Could you please take a look if it does make sense.

[amvanbaren]

@filiptronicek @svor It makes the webui read only in the sense that you can exclude the publish and login buttons from the menu content.

The open-vsx.org repo shows how to customize the menu content:
https://github.com/EclipseFdn/open-vsx.org/blob/43c654cf6e567bb720749d4323996bc23598e81b/website/src/page-settings.tsx#L190-L191
https://github.com/EclipseFdn/open-vsx.org/blob/main/website/src/menu-content.tsx

[svor]

@amvanbaren thank you, this looks great! However, in the case of a private OpenVSX registry, I would prefer not to add a dummy OAuth2 configuration in the application.yaml. Instead, it would be more convenient to simply omit the configuration. In this scenario, the Publish and Login buttons would not be displayed in the UI by default, eliminating the need for any additional UI customization.

[amvanbaren]

@svor I tried your PR (#1057). The dynamic approach causes a slight glitch. The white screen is when I do a page refresh.

Here the isOAuth2Enabled initial value is false and the API returns true:

login-popin.webm

Here the isOAuth2Enabled initial value is true and the API returns true:

login-nochange.webm

the Publish and Login buttons would not be displayed in the UI by default

No, that would be a breaking change. open-vsx.org and other deployments expect the Publish and Login buttons to be displayed by default. Here the isOAuth2Enabled initial value is true and the API returns false. Does this work for you?

login-popout.webm

[svor]

@amvanbaren I've answered in my PR #1057 (comment), please take a look.