Changes to the Benchmark Suite #2 #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jerimiah <Jerimiah.wright@utexas.edu>
|
|
amccaskey
suggested changes
Jun 5, 2020
| @@ -36,13 +36,18 @@ def execute(self, inputParams): | |||
| elif inputParams['Observable']['name'] == 'fermion': | |||
| obs_str = inputParams['Observable']['obs_str'] | |||
| H = xacc.getObservable('fermion', obs_str) | |||
|
|
|||
| elif inputParams['Observable']['name'] == 'psi4': | |||
There was a problem hiding this comment.
These 2 elifs provide the same code, you should remove the pyscf one and replace the one elif with
elif inputParams['Observable']['name'] in ['pyscf','psi4']:There was a problem hiding this comment.
I fixed this - Do I need to make a new pull request in order for the new changes to take effect?
…stry_benchmark.py Signed-off-by: Jerimiah <Jerimiah.wright@utexas.edu>
amccaskey
approved these changes
Jun 5, 2020
danclaudino
pushed a commit
to danclaudino/xacc
that referenced
this pull request
Sep 16, 2020
Changes to the Benchmark Suite #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jerimiah Jerimiah.wright@utexas.edu
Added a toggle to the output logs generated by the benchmark suite. The default is no output log. Also added a return statement for the buffer, so you can interact with the data after running the suite. (xacc.py)
Fixed an initialization issue with the pyscf observable (pyscf_observable.py)
Added pyscf and adapt-vqe and its keywords to the benchmark suite (chemistry_benchmark.py)