Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update JSON Forms to 3.2.0-beta.0 #76

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

LukasBoll
Copy link
Contributor

No description provided.

@LukasBoll
Copy link
Contributor Author

Hi @sdirix,
I updated the angular version, which needs a newer node version.
We need to update the node version to >18.13 in our build step to build the project.

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LukasBoll, I did not test this yet but I noticed you used different Angular versions for the dependencies. Some use 16.x versions and some 17.x versions. All of them should use Angular 16 (i.e. the lower supported version).

package.json Outdated
"@angular/common": "^17.0.8",
"@angular/compiler": "^17.0.8",
"@angular/core": "^17.0.8",
"@angular/flex-layout": "^15.0.0-beta.42",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angular/flex-layout should not be needed anymore. Thus the dependency can be removed

@LukasBoll
Copy link
Contributor Author

Hi @LukasBoll, I did not test this yet but I noticed you used different Angular versions for the dependencies. Some use 16.x versions and some 17.x versions. All of them should use Angular 16 (i.e. the lower supported version).

Hi @lucas-koehler,
Thanks! I changed the angular version consistent to 16 and removed the unneeded flex-layout

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LukasBoll thanks for the update! I added an .nvmrc file to specify the node version used by Netlify and updated the dependencies and unit testing a bit.

@lucas-koehler lucas-koehler merged commit c69cd03 into eclipsesource:master Jan 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants