-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update JSON Forms to 3.2.0-beta.0 #76
update JSON Forms to 3.2.0-beta.0 #76
Conversation
Hi @sdirix, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LukasBoll, I did not test this yet but I noticed you used different Angular versions for the dependencies. Some use 16.x versions and some 17.x versions. All of them should use Angular 16 (i.e. the lower supported version).
package.json
Outdated
"@angular/common": "^17.0.8", | ||
"@angular/compiler": "^17.0.8", | ||
"@angular/core": "^17.0.8", | ||
"@angular/flex-layout": "^15.0.0-beta.42", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@angular/flex-layout
should not be needed anymore. Thus the dependency can be removed
61cac00
to
dfe1e64
Compare
Hi @lucas-koehler, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LukasBoll thanks for the update! I added an .nvmrc
file to specify the node version used by Netlify and updated the dependencies and unit testing a bit.
No description provided.