Skip to content

Make mapStateToControl return same instance for same input #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eneufeld opened this issue Mar 11, 2019 · 0 comments
Closed

Make mapStateToControl return same instance for same input #1292

eneufeld opened this issue Mar 11, 2019 · 0 comments
Assignees
@eneufeld
Milestone
2.2.3

Comments

@eneufeld
Copy link
Member

Describe the bug
The mapStateTo*Props methods do not return an object which can be shallow compared to a previous version for the same input. This leads to unnecessary updates of components .

Expected behavior
mapStateTo*Props methods return an object which can be shallow compared to a previous version for the same input.
@eneufeld eneufeld mentioned this issue Mar 11, 2019
Closed
2 tasks
@edgarmueller edgarmueller added this to the 2.2.3 milestone Mar 22, 2019
eneufeld added a commit to eneufeld/jsonforms that referenced this issue Apr 2, 2019
@eneufeld
Improve performance of the Material Renderer Set
4f3149e 
* Fix eclipsesource#1292
* changed the findUISchema helper method to not rely on a state
* Controls calculate the merge of configs themself
* Change StatePropsOfControl `errors` to string
* Removed unnecessary functions in props
* Use React.memo for functional components
* Update enzyme to handle React.memo
* Fix ionic and angular tests that poped up
* Improve data output in examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eneufeld eneufeld

Labels
None yet
Projects
None yet
Milestone
2.2.3
Development

No branches or pull requests
2 participants
@edgarmueller @eneufeld