Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[angular] table does not correctly propagate read-only state to children #1479

Closed
edgarmueller opened this issue Aug 20, 2019 · 2 comments · Fixed by #2062
Closed

[angular] table does not correctly propagate read-only state to children #1479

edgarmueller opened this issue Aug 20, 2019 · 2 comments · Fixed by #2062
Assignees
@LukasBoll
Labels
angular est-2 material
Milestone
3.1

Comments

@edgarmueller
Copy link
Contributor

Describe the bug
When setting an UI schema containing a table to readonly, its children are still enabled.
@sdirix sdirix added this to the 2.3.2 milestone Aug 23, 2019
@sdirix sdirix added the est-2 label Sep 5, 2019
@sdirix sdirix modified the milestones: 2.3.2, 2.4.0 Nov 21, 2019
@sdirix sdirix modified the milestones: 2.4.0, 2.5.0 Mar 12, 2020
@sdirix sdirix modified the milestones: 2.5.0, Backlog, next Feb 2, 2021
@sdirix
Copy link
Member

sdirix commented Nov 8, 2022

@LukasBoll Can you check whether this still occurs or was fixed in the mean time?

@LukasBoll
Copy link
Contributor

LukasBoll commented Nov 23, 2022 •
edited
Loading

Readonly works for tables and is propagated correctly to all children.
But I also checked the detail-list and this one doesn’t work!

@sdirix sdirix modified the milestones: next, 3.x, 3.1 Nov 29, 2022
LukasBoll added a commit to LukasBoll/jsonforms that referenced this issue Dec 6, 2022
@LukasBoll
propagate readOnly prop in Angular detail-List
1376f3b 
closes eclipsesource#1479
@LukasBoll LukasBoll mentioned this issue Dec 14, 2022
Merged
sdirix pushed a commit that referenced this issue Jan 5, 2023
@LukasBoll
Propagate read only in Angular Material master detail
3b32c9b 
When an Angular Material master detail control is set to read only, it
will now also render its detail as read only with the same mechanism
used in the other Angular Material renderers.

Closes #1479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LukasBoll LukasBoll

Labels
angular est-2 material
Projects
None yet
Milestone
3.1
Development

Successfully merging a pull request may close this issue.

propagate readOnly prop in Angular detail-List LukasBoll/jsonforms
3 participants
@edgarmueller @sdirix @LukasBoll