Skip to content

Register the radio control and use RankedTester to detect format: radio #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

iggh
Copy link
Contributor

@iggh iggh commented Mar 21, 2019

The radio controller was developed but wasn’t exported with a result I could use.

Export materialRadioGroupControlTester with rankedTester to be called by:

options {
    format: "radio"
}

Register MaterialRadioGroupControl and MaterialRadioGroupControlTester on packages/material/src/controls/index.ts and packages/material/src/index.ts in order to be globally available

Please let me know if any specific tests need to be added and/or point me in the right direction if this doesn't pass the test criteria.

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2019

CLA assistant check
All committers have signed the CLA.

@iggh iggh force-pushed the bugfix/register-radio-control branch from afb983c to 84cc0ec Compare March 22, 2019 09:57
@edgarmueller edgarmueller self-requested a review March 22, 2019 15:01
@edgarmueller
Copy link
Contributor

edgarmueller commented Mar 22, 2019

Thanks for the PR! Once the formatter issues are solved, we can merge this (run npm run check-format at the root and it'll tell which files are violating formatting guidelines).

@edgarmueller edgarmueller added this to the 2.2.3 milestone Mar 22, 2019
@iggh iggh force-pushed the bugfix/register-radio-control branch from 84cc0ec to 835cc67 Compare March 22, 2019 16:37
@iggh
Copy link
Contributor Author

iggh commented Mar 22, 2019

Thanks for the pointer. Hopefully this now covers it.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 89.14% when pulling 835cc67 on iggh:bugfix/register-radio-control into 46a14f1 on eclipsesource:master.

@edgarmueller
Copy link
Contributor

Yep, looks good. Thanks!

@edgarmueller edgarmueller merged commit 38078fa into eclipsesource:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants