Issue 1884 #1968
Merged
Issue 1884 #1968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@sdirix can you please review. |
Member
|
Thanks for the PR. We'll take a look soon! |
sdirix
reviewed
Jul 15, 2022
Member
sdirix
left a comment
sdirix
left a comment
There was a problem hiding this comment.
Coincidentally we performed the same change in another PR ;)
Still the example app improvement is very appreciated!
sdirix
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing the issue #1884
To check that run vue-vanilla renderer set (using cd packages/vue/vue-vanilla && npm run serve)
and then select the newly added example - Issue 1884 and check that when the committer checkbox is selected only then the address text fields are enabled.