[Design] Show timeline behind expanded track groups #122
Conversation
ALevansSamsung
changed the title
There was a problem hiding this comment.
Looks as advertised: the grid is always continuous and the summary track (when present) always shows.
But the selection behaviour of groups is wonky. It requires multiple clicks to deselect and even then, sometimes it doesn't deselect all members of the group. Moreover, when initially drawing the selection, if it only overlaps some of the tracks of an expanded group the selection nonetheless takes in all of the other tracks in that group that I didn't draw the mouse over. See the very beginning of this screen grab for that selection rectangle behaviour.
There was a problem hiding this comment.
It's not clear to me what has changed ... the selection state of a group as controlled at the group level is still wildly inconsistent.
On the matter of the initial selection range, on reflection I think there's no issue there: the rubber-band is clearly previewing that the whole group will be selected when dragging the pointer over a part of it, so I think that's a clear communication to the user of what will happen.
My latest change was suppose to make the checkboxes select and deselect children recursively. I'll test again. |
|
Ok, it seems that scrolling over a track group and then also its children causes some tracks to be saved as selected multiple times therefore when they are deselected they are only deselecting the one iteration. |
Oh yeah, that makes sense. In fact, my GIF I think captured this? I notice that the tracks in the "Memory Usage" group that had sticky selection were the ones that my mouse pointer actually dragged over. Others that were included in the extended selection rubber-band were not so sticky. |
| @@ -158,20 +158,20 @@ export class PanelContainer implements m.ClassComponent<Attrs> { | |||
| startY, | |||
| endY); | |||
| // Get the track ids from the panels. | |||
| const tracks = []; | |||
| const tracks = new Set<string>(); | |||
ALevansSamsung
deleted the
design/show-timeline-behind-expanded-track-groups
branch
What it does
Show summary tracks when track groups are expanded rather then dead space
Based on the Argo designs it seems that rather than highlighting expanded track groups in this way, we would just show an empty track content. From my perspective we could instead display the track group's summary track.
It would look something like this:
Also markers like notes would show through like normal tracks
This will fix this issue: https://github.com/android-graphics/sokatoa/issues/519
May also fix: https://github.com/android-graphics/sokatoa/issues/469