Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for Android theme configuration #2264

Closed
cpetrov opened this issue Jul 4, 2023 · 0 comments · Fixed by #2265
Closed

Update documentation for Android theme configuration #2264

cpetrov opened this issue Jul 4, 2023 · 0 comments · Fixed by #2265
Labels
bug

Comments

@cpetrov
Copy link
Member

cpetrov commented Jul 4, 2023

Problem description

Since Tabris.js 3.9, the app theme on Android cannot be configured by setting the Theme preference anymore. The preference AndroidPostSplashScreenTheme should be set instead. See #2261.

The documentation however still states that the Theme preference should be configured.

Expected behavior

The documentation should be updated to use the preference name AndroidPostSplashScreenTheme instead of Theme.

Environment

  • Tabris.js version: 3.9
@cpetrov cpetrov added the bug label Jul 4, 2023
@mpost mpost mentioned this issue Jul 4, 2023
Merged
mpost added a commit that referenced this issue Jul 4, 2023
@mpost
Update android theming docs to reflect cordova 11 change
e2c73b2 
With the removal of the Tabris.js specific splash screen theming
mechanism, the default cordova mechanism is now used. This change
updated the docs to reflect those new capabilities.

Fixes #2264
mpost added a commit that referenced this issue Jul 4, 2023
@mpost
Update android theming docs to reflect cordova 11 change
239b723 
With the removal of the Tabris.js specific splash screen theming
mechanism, the default cordova mechanism is now used. This change
updated the docs to reflect those new capabilities.

Fixes #2264
mpost added a commit that referenced this issue Jul 4, 2023
@mpost
Update android theming docs to reflect cordova 11 change
55c0c0d 
With the removal of the Tabris.js specific splash screen theming
mechanism, the default cordova mechanism is now used. This change
updated the docs to reflect those new capabilities.

Fixes #2264
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update android theming docs to reflect cordova 11 change eclipsesource/tabris-js
1 participant
@cpetrov