Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for widget manager & open handler #5

Closed
wants to merge 1 commit into from

Conversation

tortmayr
Copy link

  • Document 'WidgetManager' and related interfaces
  • Document 'WidgetOpenHandler' and related interfaces
    Signed-off-by: Tobias Ortmayr tortmayr@eclipsesource.com
    Contributed on behalf of STMicroelectronics

Copy link

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks! I added a few suggestions inline!

packages/core/src/browser/widget-manager.ts Outdated Show resolved Hide resolved
packages/core/src/browser/widget-open-handler.ts Outdated Show resolved Hide resolved
packages/core/src/browser/widget-open-handler.ts Outdated Show resolved Hide resolved
packages/core/src/browser/widget-open-handler.ts Outdated Show resolved Hide resolved
packages/core/src/browser/widget-open-handler.ts Outdated Show resolved Hide resolved
packages/core/src/browser/widget-open-handler.ts Outdated Show resolved Hide resolved
packages/core/src/browser/widget-open-handler.ts Outdated Show resolved Hide resolved
packages/core/src/browser/widget-open-handler.ts Outdated Show resolved Hide resolved
@tortmayr
Copy link
Author

Thanks. I applied your suggestions and squased the commits.

@planger planger self-requested a review September 30, 2020 07:58
Copy link

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

FIxes  eclipse-theia#8643
- Document 'WidgetManager' and related interfaces
- Document 'WidgetOpenHandler' and related interfaces
Signed-off-by: Tobias Ortmayr <tortmayr@eclipsesource.com>
Contributed on behalf of STMicroelectronics
@sdirix
Copy link
Member

sdirix commented Nov 16, 2022

Merged upstream with eclipse-theia#8644

@sdirix sdirix closed this Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants