Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nab atlas gpu field #89

Open
wants to merge 61 commits into
base: develop
Choose a base branch
from
Open

Nab atlas gpu field #89

wants to merge 61 commits into from

Conversation

sbrdar
Copy link
Collaborator

@sbrdar sbrdar commented May 29, 2024

  • add support for packing of nD-array variables into an (n+1)D-array using atlas::MultiField
  • add src/cloudsc_gpu_atlas test for using Atlas GPU offloading with CUDA backend: has to be configured as "--with-atlas --with-gpu --with-cuda" using the bundle.yml
  • Atlas support 'pageable', 'pinned', and 'pinned + mapped' memory settings on the host and the device for offloading
  • temporarily switch to Atlas' branch 'feature/gpu_discontiguous_data'

sbrdar added 30 commits April 8, 2024 16:21
@sbrdar
use eigen/3.4.0 to prevent redifinitions stemming from EIGEN_COMP_PGI…
f5fa744 
… when using CUDA
@sbrdar
enable GPU for Atlas & temporary disable other GPU implementations
fe8f85f
@sbrdar
add Atlas GPU implementation
3bcde0a
@sbrdar
adapt to FIELD_API implementation
e75fcb7
@sbrdar
revert temporary disabled features
1cf62ac
@sbrdar
remove unnecessary code
9b60712
@sbrdar
correct the field_api git version
2b20918
@sbrdar
fix a bug to have identical results to FIELD_API dwarf version
dc3e5bb
@sbrdar
use memory pinning for NVHPC - same as the FIELD_API version
2b1242d
@sbrdar
remove debugging print outs
1123086
@sbrdar
temporary disable atlas::Multifield until it is merged in the develop…
dc83f52 
… branch of Atlas
@sbrdar
set ACC flags
12a5d63
@sbrdar
1) use atlas::FieldSet GPU-functions instead of relying on multiple c…
569bd7c 
…alls to atlas::Field GPU-ones; 2) add scc-hoist-atlas
@sbrdar
use a preprocessor switch for scc and scc-hoist
db385d4
@sbrdar
adapt cloudsc_gpu_atlas to use host memory pinning + device mapping i…
07abfda 
…n Atlas Field
@sbrdar
enable MultiField for Atlas data structures, switch temporary to an A…
067cb3d 
…tlas branch until -develop- becomes merged
@sbrdar
add MultiField implementation for GPU
31ef6db
@sbrdar
make scc-hoist-atlas use multifield
809dc55
@sbrdar
update README with the Atlas GPU features
f67b7d5
@sbrdar
use eigen/3.4.0 to prevent redifinitions stemming from EIGEN_COMP_PGI…
10fb03a 
… when using CUDA
@sbrdar
enable GPU for Atlas & temporary disable other GPU implementations
cec30c2
@sbrdar
add Atlas GPU implementation
8d02805
@sbrdar
adapt to FIELD_API implementation
53dec63
@sbrdar
revert temporary disabled features
5d097b8
@sbrdar
remove unnecessary code
739cf5b
@sbrdar
correct the field_api git version
8de3441
@sbrdar
fix a bug to have identical results to FIELD_API dwarf version
c0e2d1d
@sbrdar
use memory pinning for NVHPC - same as the FIELD_API version
5bc6f38
@sbrdar
remove debugging print outs
ff69001
@sbrdar
temporary disable atlas::Multifield until it is merged in the develop…
a313908 
… branch of Atlas
@sbrdar sbrdar requested a review from reuterbal May 29, 2024 16:35
wdeconinck and others added 16 commits October 15, 2024 16:50
@wdeconinck @sbrdar
new Lumi modules environment
24c8bb4
@sbrdar
move kernel into a subroutine (needed for acc deviceptr on Lumi)
a888819
@sbrdar
remove unused included module
fa98317
@sbrdar
add host-allocation, device-allocation timers in src/cloudsc_gpu_atlas
ee141b6
@sbrdar
use standard timer for atlas device allocation
bbd82aa
@sbrdar
fix path to custom CMake on gh1 of ecmwf
312db3c
@sbrdar
add k_caching and hoist kernels of cloudsc in cloudsc_gpu_atlas
8679962
@sbrdar
remove an unused file
945d79c
@sbrdar
cosmetics in Atlas gpu version
a11ec71
@sbrdar
do not time the d2h offload, it is not compatible with -managed- and …
68967f9 
…-zerocopy- which need to be touched on the host to account for d2h offload
@sbrdar
validation only done for the environment variable NITER=1
3201cf6
@sbrdar
use pluto device pool for hoisted variables
f951dff
@sbrdar
fix cray compilation
98a2c14
@sbrdar
fix usage of envirnoment variable HOIST_POOL
6754ae7
@sbrdar
fix the bug of FIELD RANK NOT SUPPORTED for Atlas GPU validation
21402f7
@sbrdar
use the new atlas::MultiField constructor
5303667
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reuterbal reuterbal Awaiting requested review from reuterbal

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrdar @wdeconinck