Fix omp update directive in trgtol_mod (no MPI code path) #212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very minor PR correcting an OMP directive when building ECTrans without MPI, for PR #211
I used the test program from @samhatfield's comment here to verify the OMP implementation on the GPU on MI300A with and without unified memory enabled. I am getting identical results in both cases!
Here are the results running on MI300A in "discrete GPU" mode (HSA_XNACK=0):
single precision:
double precision:
With unified memory enabled (HSA_XNACK=1):
single precision:
double precision: