Most recent "accord" version, with ECMWF-compatible copyright headers #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But... NVHPC 23.7 was setting it false by default GCC 12.2 was setting it true by default
…_VIEW only if necessary
Option was removed in NVHPC 23.9
dareg
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Looks fine to me.
Maybe we could readd the acknowledgement of the buddy_alloc lib in the readme, as in this commit: ACCORD-NWP/field_api@e02f8ab#diff-1550ec65ac92f65817fc28928dfef526912b5f52356ff43651369bae92f56031
Yes it was buried in the license change commit, sorry for that...
|
@dareg Good catch, and thank you for the prompt review. I have re-instated the acknowledgement and I'll merge this now and release the subsequent state under the |
Merged
pmarguinaud
added a commit
to pmarguinaud/field_api
that referenced
this pull request
Dec 4, 2023
Fix tests and gfortran compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in the most recent advances of the "accord" branch, rebased over the adapted ECWMF copyright headers.
@dareg Please confirm that this is in line with what you would expect by approving this PR. As discussed offline, I would then like to roll a release tag for reference before commencing development merges.