#6: Implemented DataHandler class and extract/remove/namelist #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
=======================================
Coverage ? 85.67%
=======================================
Files ? 16
Lines ? 1005
Branches ? 0
=======================================
Hits ? 861
Misses ? 144
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See issue #6)
Added support for data pipelines to
ifsbench. The main feature is aDataHandlerbase class that can perform a given action on a working directory. Currently I've implemented:RenameHandler- for moving/renaming/copying files, using regular expressions.NamelistHandler- for modifying namelists.ExtractHandler- for extracting archives.Talking points / request for feedback:
InputFileconcept that we've used before (with file hashes and other things). If you think that this should be included, I'd be happy about some suggestions.RenameHandler.RenameModefor example). It's a bit clunky to write but I haven't come up with a better solution.