Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve_vector_notation: fix/improvement #454

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

MichaelSt98
Copy link
Collaborator

Imagine having

INTEGER :: ARR(N)

ARR(:) = 1
ARR(1:5) = 1

DO J=1,N
 ...
ENDDO

This would have been transformed to

DO JL=1,N
  ARR(JL) = 1
ENDDO
DO JL=1,N
  ARR(JL) = 1
ENDDO

With this PR it is instead transformed to:

DO JL=1,N
  ARR(JL) = 1
ENDDO
DO i_arr_0=1,5
  ARR(i_arr_0) = 1
ENDDO

or if a loop DO JL=1,5 exists to:

DO JL=1,N
  ARR(JL) = 1
ENDDO
DO JL=1,5
  ARR(JL) = 1
ENDDO

Copy link

github-actions bot commented Dec 2, 2024

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/454/index.html

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.29%. Comparing base (ba7e230) to head (36b1775).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #454   +/-   ##
=======================================
  Coverage   93.28%   93.29%           
=======================================
  Files         220      220           
  Lines       41202    41224   +22     
=======================================
+ Hits        38436    38458   +22     
  Misses       2766     2766           
Flag Coverage Δ
lint_rules 96.39% <ø> (ø)
loki 93.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good to me too!

@reuterbal reuterbal merged commit e9760e8 into main Dec 2, 2024
13 checks passed
@reuterbal reuterbal deleted the nams-resolve-vector-notation-dims-specified branch December 2, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants