PoolAllocator improvement

[MichaelSt98]

improvement so that stack size calculation and incrementing guarantees 8 byte alignment.

With this,

    ISTSZ = (C_SIZEOF(REAL(1, kind=JPRB))*NPROMA + 13*C_SIZEOF(REAL(1, kind=JPRB))*NLEV*NPROMA + 5*C_SIZEOF(REAL(1, kind=JPRB)) &
    & *NLEV*NPROMA*NCLV + C_SIZEOF(REAL(1, kind=JPRB))*NPROMA*NCLV) / C_SIZEOF(REAL(1, kind=JPRB))
    IF (.not.(MOD(C_SIZEOF(REAL(1, kind=JPRB))*NPROMA + 13*C_SIZEOF(REAL(1, kind=JPRB))*NLEV*NPROMA + 5*C_SIZEOF(REAL(1,  &
    & kind=JPRB))*NLEV*NPROMA*NCLV + C_SIZEOF(REAL(1, kind=JPRB))*NPROMA*NCLV, C_SIZEOF(REAL(1, kind=JPRB))) == 0)) ISTSZ = ISTSZ &
    &  + 1

becomes:

    ISTSZ = ISHFT(7 + C_SIZEOF(REAL(1, kind=JPRB))*NPROMA + C_SIZEOF(REAL(1, kind=JPRB))*NLEV*NPROMA, -3) + 12*ISHFT(7 +  &
    & C_SIZEOF(REAL(1, kind=JPRB))*NLEV*NPROMA, -3) + 4*ISHFT(7 + C_SIZEOF(REAL(1, kind=JPRB))*NLEV*NPROMA*NCLV, -3) + ISHFT(7 +  &
    & C_SIZEOF(REAL(1, kind=JPRB))*NPROMA*NCLV + C_SIZEOF(REAL(1, kind=JPRB))*NLEV*NPROMA*NCLV, -3)

Further,

    YLSTACK_L = YLSTACK_L + KLON*(KLEV + 1)*C_SIZEOF(REAL(1, kind=JPRB))
    IP_ZTP1 = YLSTACK_L
    YLSTACK_L = YLSTACK_L + KLON*KLEV*C_SIZEOF(REAL(1, kind=JPRB))
    IP_ZLI = YLSTACK_L
    YLSTACK_L = YLSTACK_L + KLON*KLEV*C_SIZEOF(REAL(1, kind=JPRB))

becomes:

    YLSTACK_L = YLSTACK_L + ISHFT(ISHFT(KLON*(KLEV + 1)*C_SIZEOF(REAL(1, kind=JPRB)) + 7, -3), 3)
    IP_ZTP1 = YLSTACK_L
    YLSTACK_L = YLSTACK_L + ISHFT(ISHFT(KLON*KLEV*C_SIZEOF(REAL(1, kind=JPRB)) + 7, -3), 3)
    IP_ZLI = YLSTACK_L
    YLSTACK_L = YLSTACK_L + ISHFT(ISHFT(KLON*KLEV*C_SIZEOF(REAL(1, kind=JPRB)) + 7, -3), 3)

and for cray_ptr_loc_rhs=True

    IP_ZICEFRAC = LOC(ZSTACK(YLSTACK_L))
    YLSTACK_L = YLSTACK_L + KLON*KLEV
    IP_ZQX = LOC(ZSTACK(YLSTACK_L))
    YLSTACK_L = YLSTACK_L + KLON*KLEV*NCLV

becomes:

    IP_ZICEFRAC = LOC(ZSTACK(YLSTACK_L))
    YLSTACK_L = YLSTACK_L + ISHFT(KLON*KLEV*C_SIZEOF(REAL(1, kind=JPRB)) + 7, -3)
    IP_ZQX = LOC(ZSTACK(YLSTACK_L))
    YLSTACK_L = YLSTACK_L + ISHFT(KLON*KLEV*NCLV*C_SIZEOF(REAL(1, kind=JPRB)) + 7, -3)

[github-actions]

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/481/index.html

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.17%. Comparing base (48c5cbf) to head (e79d1da).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #481      +/-   ##
==========================================
- Coverage   96.17%   96.17%   -0.01%     
==========================================
  Files         224      224              
  Lines       40386    40336      -50     
==========================================
- Hits        38842    38793      -49     
+ Misses       1544     1543       -1     

Flag	Coverage Δ
lint_rules	96.39% <ø> (ø)
loki	96.16% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.