Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept frequency in minute in dataset names #153

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

floriankrb
Copy link
Member

@floriankrb floriankrb commented Dec 3, 2024

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.96%. Comparing base (7f7b181) to head (fb5b8e3).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #153   +/-   ##
========================================
  Coverage    72.96%   72.96%           
========================================
  Files           10       10           
  Lines          825      825           
========================================
  Hits           602      602           
  Misses         223      223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@b8raoult b8raoult merged commit ddee516 into develop Dec 3, 2024
57 of 58 checks passed
@b8raoult b8raoult deleted the feature/naming branch December 3, 2024 13:12
@floriankrb floriankrb mentioned this pull request Dec 3, 2024
b8raoult added a commit that referenced this pull request Dec 7, 2024
* better error messages

* Fix division-by-zero when computing statistics for a single-time dataset (#142)

* accept frequency in minute in dataset names (#153)

* link to naming conventions

* fix negative variance  for constant variables (#148)

---------

Co-authored-by: Baudouin Raoult <baudouin.raoult@ecmwf.int>
Co-authored-by: Mikko Partio <mikko.partio@fmi.fi>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: b8raoult <53792887+b8raoult@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants