-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
…uency-ignoring-config-settings
Hi, I tested this branch and the various profilers all worked as expected. Nice work! At first, some of the memory profiler output can be confusing. It shows negative numbers, and positive numbers greater then max device memory. Turns out this is because the profiler tracks deallocations, and aggregates allocations across the entire program runtime. Maybe we could add a note above the memory profiler output explaining this. Or maybe better to link to the documentation for the profiler in stdout, as I understand there's more options which can be enabled if the user digs into the code | Name | ... | CUDA Mem | Self CUDA Mem | # of Calls | ... |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…nemoi-training into mlflow_benchmark_profiler_update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks very much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Just a minor comment about the class inheritance.
Describe your changes
PR to update the benchmark profiler to be able to:
Please also include relevant motivation and context.
Previous version of the BP did not allow to configure the exact reports to be generated and did not make use of torch profiler. In this PR we address those issues, allowing one to choose what reports to generate, exploiting the features available in pytorch profiler for a more in depth breakdown of GPU/CPU memory usage and adding the option to generate a model summary
List any dependencies that are required for this change.
When running the memory report generation, it's possible to perform a Holistic Trace Analysis but for that you'd need to install https://hta.readthedocs.io/en/latest/source/intro/installation.html (so this is now included as extras for the profiler in setup.py)
Type of change
Please delete options that are not relevant.
Issue ticket number and link
We did not create a ticket when we first started working on this task. Will do next time, apologies!
Checklist before requesting a review
*need to still update the confluence page but docstrings and comments are updated
Tag possible reviewers
You can @-tag people to review this PR in addition to formal review requests.
@cathalobrien @mchantry @JesperDramsch
[PR Migrated from aifs-mono to anemoi-training]
📚 Documentation preview 📚: https://anemoi-training--38.org.readthedocs.build/en/38/