Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove verify: 0 from example config #94

Merged

Conversation

matrss
Copy link

@matrss matrss commented Feb 7, 2024

This configuration option disables certificate verification, which should never be done. Having it be part of the example config in the readme makes it easy to accidentally copy and paste this dangerous configuration option.

Fixes #90.

I would go so far as to suggest to remove the option to disable certificate verification completely. There is basically no legitimate reason to do it. But that would be a larger change than this.

This configuration option disables certificate verification, which
should never be done. Having it be part of the example config in the
readme makes it easy to accidentally copy and paste this dangerous
configuration option.
@FussyDuck
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gbiavati gbiavati merged commit 133836a into ecmwf:master Apr 24, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeating InsecureRequestWarning at every download
3 participants