Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converted files fail on CF-Conventions checkers. #36

Closed
alexamici opened this issue Dec 5, 2018 · 1 comment
Closed

Converted files fail on CF-Conventions checkers. #36

alexamici opened this issue Dec 5, 2018 · 1 comment
Assignees
@alexamici
Labels
bug Something isn't working

Comments

@alexamici
Copy link
Contributor

Using the Reading University on-line checker on current master we fail in an embarrassing way: WARN: (2.6.1): No 'Conventions' attribute present 😞.

Including some level of compliance checking in unit tests would be ideal.
@alexamici alexamici added bug Something isn't working enhancement New feature or request labels Dec 5, 2018
@alexamici alexamici self-assigned this Dec 5, 2018
alexamici added a commit that referenced this issue Dec 5, 2018
@alexamici
Declare the compliance to the CF Conventions. Fx the bug part of #36.
f082770
alexamici added a commit that referenced this issue Dec 5, 2018
@alexamici
Add CF attributes to a heightAboveGround coordinate. #36
2c1bb12
@alexamici alexamici removed the bug Something isn't working label Dec 5, 2018
alexamici added a commit that referenced this issue Dec 6, 2018
@alexamici
Sync docs with #36.
edab7cd
alexamici added a commit that referenced this issue Dec 6, 2018
@alexamici
Header coordinate are always CF compliant. #36
ca1eea8
@alexamici alexamici added bug Something isn't working and removed enhancement New feature or request labels Dec 6, 2018
@alexamici
Copy link
Contributor Author

Converting to netCDF via xarray both with and without cf2cdm conversion now result in a file complying to CF conventions in all tested cases according to on-line checkers:

>>> ds = xr.open_dataset('file.grib', engine='cfgrib')
>>> ds.to_netcdf('file.nc')
>>> cf2cdm.translate_coords(ds, coord_model=cf2cdm.CDS).to_netcdf('file_cdm.nc')

A more comprehensive compliance testing is left to another issue.

@alexamici alexamici changed the title Add (automatic?) testing against a CF-Conventions checker. Converted files fail on CF-Conventions checkers. Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexamici alexamici

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexamici