Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xarray entrypoint #203

Merged
merged 20 commits into from
Mar 16, 2021
Merged

Xarray entrypoint #203

merged 20 commits into from
Mar 16, 2021

Conversation

aurghs
Copy link
Contributor

@aurghs aurghs commented Feb 23, 2021

  • Add the external interface as a plugin for xarray.

  • Fix circular dependency using xarray by removing from .xarray_to_grib import to_grib in the init.

  • Add some test

  • passed black

@FussyDuck
Copy link

FussyDuck commented Feb 23, 2021

CLA assistant check
All committers have signed the CLA.

@aurghs aurghs closed this Feb 23, 2021
@aurghs aurghs reopened this Feb 23, 2021
@codecov-io
Copy link

codecov-io commented Feb 24, 2021

Codecov Report

Merging #203 (a481ac1) into stable/0.9.9.x (de89716) will decrease coverage by 42.14%.
The diff coverage is 4.59%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           stable/0.9.9.x     #203       +/-   ##
===================================================
- Coverage           96.53%   54.38%   -42.15%     
===================================================
  Files                  23       25        +2     
  Lines                1615     1699       +84     
  Branches              191      196        +5     
===================================================
- Hits                 1559      924      -635     
- Misses                 34      761      +727     
+ Partials               22       14        -8     
Impacted Files Coverage Δ
cfgrib/__init__.py 100.00% <ø> (ø)
cfgrib/xarray_entrypoint.py 0.00% <0.00%> (ø)
tests/test_50_xarray_plugin.py 16.66% <16.66%> (ø)
cf2cdm/cfunits.py 0.00% <0.00%> (-100.00%) ⬇️
cf2cdm/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
cf2cdm/cfcoords.py 0.00% <0.00%> (-100.00%) ⬇️
cf2cdm/datamodels.py 0.00% <0.00%> (-100.00%) ⬇️
tests/test_40_xarray_store.py 4.54% <0.00%> (-95.46%) ⬇️
tests/test_20_cfcoords.py 5.95% <0.00%> (-94.05%) ⬇️
tests/test_50_xarray_getitem.py 7.31% <0.00%> (-92.69%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de89716...a481ac1. Read the comment docs.

@alexamici alexamici merged commit 6d152d6 into ecmwf:stable/0.9.9.x Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants