-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace distutils.version #318
Conversation
Many thanks @headtr1ck! I've allowed the tests to run, and as you can see there are some errors, which maybe you didn't get on your system. |
Can you try again? I think I fixed all the problems. |
this time with isort... |
Codecov ReportBase: 95.49% // Head: 95.49% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #318 +/- ##
=======================================
Coverage 95.49% 95.49%
=======================================
Files 26 26
Lines 2018 2020 +2
Branches 233 233
=======================================
+ Hits 1927 1929 +2
Misses 61 61
Partials 30 30
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Thanks @headtr1ck, this was a nice little pull request, and you even updated the changelog - top marks! :) |
This PR replaces
distutils.version
bypackaging.version
to silence the DeprecationWarning in the xarray plugin.Closes #312
Also, I have added the new description and url attributes (someone might want to check these).