Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

189 auto filling cds requests with months and days is incompatible with cds selection limits #190

Conversation

EddyCMWF
Copy link
Contributor

see #189 for full details

@sandorkertesz
Copy link
Collaborator

For me the test is failing:

================================================================== FAILURES ==================================================================
_____________________________________________________ test_cds_netcdf_selection_limited ______________________________________________________

    @pytest.mark.long_test
    @pytest.mark.download
    @pytest.mark.skipif(NO_CDS, reason="No access to CDS")
    def test_cds_netcdf_selection_limited():
        s = from_source(
            "cds",
            "satellite-albedo",
            {
                "variable": "albb_bh",
                "satellite": "noaa_7",
                "sensor": "avhrr",
                "product_version": "v2",
                "horizontal_resolution": "4km",
                "year": "1983",
                "month": "01",
                "nominal_day": "10",
            },
        )
>       assert len(s) == 1
E       assert 9 == 1
E        +  where 9 = len(NetCDFFieldListReader(/var/folders/ng/g0zkhc2s42xbslpsywwp_26m0000gn/T/earthkit-data-cgr/cds-251e12d9351edf92911f73f0d23a7914d87dedc25a78f16003866a88be8bf0ef.d/c3s_ALBB-BH_19830110000000_GLOBE_AVHRR-NOAA7_V2.0.1.nc))

tests/sources/test_cds.py:102: AssertionError

@sandorkertesz sandorkertesz merged commit 431209d into develop Sep 19, 2023
11 checks passed
@sandorkertesz sandorkertesz deleted the 189-auto-filling-cds-requests-with-months-and-days-is-incompatible-with-cds-selection-limits branch September 19, 2023 09:29
@EddyCMWF
Copy link
Contributor Author

Thanks for fixing the mistake in the test :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto filling CDS requests with months and days is incompatible with CDS selection limits
2 participants