consistent pandas_read_csv_kwargs for file and CDS sources #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Latest commit is following an offline discussion to improve the visibility and explicitness of the kwarg handling in the read_csv method |
…ith-pandas-cds-files-previously-downloaded
EddyCMWF
commented
Oct 5, 2023
sandorkertesz
approved these changes
Oct 6, 2023
|
Can this be merged? |
…ith-pandas-cds-files-previously-downloaded
EddyCMWF
deleted the
180-the-file-source-is-not-able-to-open-with-pandas-cds-files-previously-downloaded
branch
malmans2
pushed a commit
to malmans2/earthkit-data
that referenced
this pull request
Oct 12, 2023
* Providing different defaults to different sources is confusing * need to specify compression method used by source * read_csv kwargs consistent for cds and file sources * improved kwarg handling of read_csv * test demonstrating that default parse_date kwargs is not a good idea * Tests for other formats * Compression removed from CSV.to_pandas kwargs, special treatment not required --------- Co-authored-by: Sandor Kertesz <Sandor.Kertesz@ecmwf.int>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #180 for full details and background.
CDS and file sources now have consistent pandas_read_csv_sources such that a resource from theCDS has the same behaviour whether opened automatically or saved for a later date. Several other small refactorisations also included.
I have not yet modified the ecmwf_api default kwargs as that has more bespoke requirements. But this is due to them being TAB sperated values, not COMMA seperated values.