196 attempt to detect filename when saving

[EddyCMWF]

What do you think of this? Maybe one to discuss in an earthkit-data meeting?
The issue #196 has the back story

[sandorkertesz]

Please can you add a comment showing some examples with explanation? #196 does not contain these.

[EddyCMWF]

Please can you add a comment showing some examples with explanation? #196 does not contain these.

Here is the example I am working towards:

s = from_source(
    "cds",
    "reanalysis-era5-single-levels",
    variable=["2t"],  #, "msl"],
    product_type="reanalysis",
    area=[50, -50, 20, 50],
    date="2007-01-01/2008-02-04",
    time="12:00",
)
s.save()

I will add to the cds notebook, and something similar in a URL notebook.

Working on this has raised a good point, it looks like we have already thrown away the real filename by the time we get to the decorator, so the filename used is the just the earthkit cache hash. I will also look into how we can handle this better.

[EddyCMWF]

Hi @sandorkertesz ,
I've reopened this PR, it now includes safety features which prevent users from over-writing the file they are reading, and we preserve the source_filename from the CDS.

I'm still not convinced by the behaviour when the result is an archive, but there are other deeper issues I have there, so I will create a new issue for that.

Eddy

[EddyCMWF]

Hi @sandorkertesz ,
Is there anything blocking this being merged?
Eddy

[sandorkertesz]

Hi @sandorkertesz , Is there anything blocking this being merged? Eddy

There are some pending comments. Otherwise, I just need to check it again, it has been a long time since I last looked into it

[EddyCMWF]

Hi @sandorkertesz , I don't see any unresolved comments, could you point me to them?

[sandorkertesz]

Hi @sandorkertesz , I don't see any unresolved comments, could you point me to them? Can you see any of them?

I am sorry, I did not submit them, so you could not see them!

[EddyCMWF]

Hi @sandorkertesz , tests are passing so hopefully good to go.
Thanks for the help!
Eddy

[sandorkertesz]

Hi @EddyCMWF, thanks for the changes, it is now in a good shape. Please squash and merge this PR.

[EddyCMWF]

Hi @EddyCMWF, thanks for the changes, it is now in a good shape. Please squash and merge this PR.

Thanks Sandor, but I don't have permissions to do the squash and merge

[sandorkertesz]

Hi @EddyCMWF, merged and the branch can be deleted.