Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfgrib does not need to be specified. #268

Closed
wants to merge 1 commit into from

Conversation

EddyCMWF
Copy link
Contributor

@EddyCMWF EddyCMWF commented Dec 1, 2023

cfgrib engine automatically detects when it is needed, hene it is not neccesary to include in open_dataset kwargs.
Additionally current implementation prevents using different engine (which we are working on)

@sandorkertesz
Copy link
Collaborator

sandorkertesz commented Dec 1, 2023

Hi @EddyCMWF, I am afraid it is not as simple as that. earthkit-data is passing itself to cfgrib as a "fieldset". If you want to use other engines the code in xarray.py should be changed (or the engine should support the same technique).

@sandorkertesz
Copy link
Collaborator

@EddyCMWF, what is the "different engine (which we are working on)"?

@EddyCMWF EddyCMWF closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants