Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix from_source called after importing GRIBReader #380

Merged
merged 2 commits into from
May 13, 2024

Conversation

sandorkertesz
Copy link
Collaborator

@sandorkertesz sandorkertesz commented May 13, 2024

Fixes #375

Please note that GRIBReader now has to be imported as:

from earthkit.data.readers.grib.file import GRIBReader

However, using this internal object in any user code is discouraged.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.63%. Comparing base (680ddec) to head (aa3e933).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #380   +/-   ##
========================================
  Coverage    89.63%   89.63%           
========================================
  Files          117      117           
  Lines         7371     7371           
  Branches       644      644           
========================================
  Hits          6607     6607           
  Misses         636      636           
  Partials       128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandorkertesz sandorkertesz merged commit e873e96 into develop May 13, 2024
80 checks passed
@sandorkertesz sandorkertesz deleted the bugfix/import-reader-breaks-from-source branch May 22, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

from_source is broken when readers are imported
2 participants