Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use warnings.warn for kwargs check in to_xarray #382

Merged
merged 2 commits into from
May 14, 2024

Conversation

sandorkertesz
Copy link
Collaborator

@sandorkertesz sandorkertesz commented May 14, 2024

Fixes #379

  • removed warnings when non-default kwargs used
  • use warnings.warn() when forced kwargs specified with non-default values

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.63%. Comparing base (e873e96) to head (de3f5dd).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #382      +/-   ##
===========================================
+ Coverage    89.60%   89.63%   +0.02%     
===========================================
  Files          117      117              
  Lines         7371     7371              
  Branches       644      644              
===========================================
+ Hits          6605     6607       +2     
  Misses         636      636              
+ Partials       130      128       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandorkertesz sandorkertesz merged commit fe0d6d2 into develop May 14, 2024
80 checks passed
@sandorkertesz sandorkertesz deleted the feature/use-warnings-warn branch May 14, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace logging.warn with warnings.warn
2 participants