Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading netcdf generated from FA file #401

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

sandorkertesz
Copy link
Collaborator

@sandorkertesz sandorkertesz commented Jun 6, 2024

This PR fixes the following NetCDF problems:

  • fix issue when fields were assigned to variables without lat-lon/x-y dimensions
  • fix getting the correct latitudes-longitudes when the variables "lat" and "lon" are used with the following mapping from x and y:
image

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.78%. Comparing base (36b2d9c) to head (c25fa7e).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #401   +/-   ##
========================================
  Coverage    89.78%   89.78%           
========================================
  Files          120      120           
  Lines         7653     7658    +5     
  Branches       675      675           
========================================
+ Hits          6871     6876    +5     
  Misses         651      651           
  Partials       131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandorkertesz sandorkertesz changed the title Fix reading netcdf with forecast_reference_time Fix reading netcdf generated from FA file Jun 6, 2024
@sandorkertesz sandorkertesz merged commit 7017b9b into develop Jun 6, 2024
82 checks passed
@sandorkertesz sandorkertesz deleted the feature/support-fa-netcdf branch June 6, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants