Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade minimum version of cdsapi #433

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

JamesVarndell
Copy link
Collaborator

The minimum version of CDSAPI has been upgraded to 0.7.1, which includes a bugfix to ensure compatibility between the new CDS beta and earthkit-data. The optional cads-api-client dependencies have also been removed, as the minimum version of cads-api-client has been upgraded within cdsapi.

@sandorkertesz
Copy link
Collaborator

sandorkertesz commented Aug 19, 2024

@JamesVarndell, please can you also change the other (yaml) files specifying version numbers?

Remove extra dependency on cads-api-client, as this is now covered by cdsapi 0.7.1
@JamesVarndell
Copy link
Collaborator Author

@JamesVarndell, please can you also change the other (yaml) files specifying version numbers?

Sorry, I forgot about conda - all done.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.14%. Comparing base (b22e2a1) to head (4439804).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #433      +/-   ##
===========================================
+ Coverage    90.11%   90.14%   +0.02%     
===========================================
  Files          122      122              
  Lines         7955     7995      +40     
  Branches       680      682       +2     
===========================================
+ Hits          7169     7207      +38     
  Misses         655      655              
- Partials       131      133       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandorkertesz sandorkertesz merged commit 81d5d6b into develop Aug 20, 2024
102 of 104 checks passed
@sandorkertesz sandorkertesz deleted the bugfix/cds-beta-compatibility branch October 14, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants