Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fieldlist indices implementation #436

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

sandorkertesz
Copy link
Collaborator

This PR refactors the implementation of the index()and indices() FieldList methods. In particular, it improves the performance when index() is called with a key not belonging to the default index keys.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.50%. Comparing base (8060550) to head (e6817eb).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #436   +/-   ##
========================================
  Coverage    90.50%   90.50%           
========================================
  Files          123      123           
  Lines         8274     8280    +6     
  Branches       693      693           
========================================
+ Hits          7488     7494    +6     
  Misses         655      655           
  Partials       131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandorkertesz sandorkertesz merged commit fb8a720 into develop Aug 30, 2024
117 checks passed
@sandorkertesz sandorkertesz deleted the feature/improve-fieldlist-indices branch August 30, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants