-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ecfs source #568
Add ecfs source #568
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #568 +/- ##
========================================
Coverage 90.14% 90.14%
========================================
Files 149 149
Lines 10972 10972
Branches 519 519
========================================
Hits 9891 9891
Misses 914 914
Partials 167 167 ☔ View full report in Codecov by Sentry. |
@@ -217,6 +228,13 @@ def __init__( | |||
self._download() | |||
|
|||
def mutate(self): | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit dangerous, since other sources like ecfs do not necessarily support "url" source features like parts or streams.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove that if you wish
src/earthkit/data/sources/ecfs.py
Outdated
LOG = logging.getLogger(__name__) | ||
|
||
|
||
class StandaloneMarsClient: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it needed here?
Works with
and