Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ecfs source #568

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Add ecfs source #568

merged 3 commits into from
Dec 16, 2024

Conversation

b8raoult
Copy link
Contributor

Works with

ekd.from_source('ecfs', '/path/to/data')

and

ekd.from_source('url', 'ec:/path/to/data')

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.14%. Comparing base (87232b6) to head (6751922).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #568   +/-   ##
========================================
  Coverage    90.14%   90.14%           
========================================
  Files          149      149           
  Lines        10972    10972           
  Branches       519      519           
========================================
  Hits          9891     9891           
  Misses         914      914           
  Partials       167      167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -217,6 +228,13 @@ def __init__(
self._download()

def mutate(self):

Copy link
Collaborator

@sandorkertesz sandorkertesz Dec 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit dangerous, since other sources like ecfs do not necessarily support "url" source features like parts or streams.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove that if you wish

LOG = logging.getLogger(__name__)


class StandaloneMarsClient:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it needed here?

@sandorkertesz sandorkertesz merged commit e7ce5e7 into develop Dec 16, 2024
106 checks passed
@sandorkertesz sandorkertesz deleted the feature/ecfs branch December 16, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants