Honour build-type specific flags in source flag override #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awnawab
force-pushed
the
feature/buildtype-source-flags
branch
from
a4130ea to
ecb5fa9
Compare
awnawab
force-pushed
the
feature/buildtype-source-flags
branch
from
ecb5fa9 to
fd29c4d
Compare
|
@wdeconinck could you please review? The macos CI tests are failing because the incorrect Fortran compiler is being set via the env variable FC. I don't think this is related to my changes. |
|
PR #68 adresses the failing CI |
|
As discussed offline, the specification of compiler flags via a json is an old, untested and almost deprecated feature, so we should not add new functionality to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source flag override via a json file currently cannot be used to specify build-type specific flags. This PR adds that capability.