Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow distinction between enabled/disabled features #69

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

marcosbento
Copy link
Collaborator

  • Add enabled/disabled features marker in project summary
  • Force once enabled features to be displayed as enabled, regardless of of any disabled use

Re Github #65

@FussyDuck
Copy link

FussyDuck commented Oct 31, 2024

CLA assistant check
All committers have signed the CLA.

@marcosbento marcosbento force-pushed the fix/better_print_summary_gh65 branch 3 times, most recently from 437c1b5 to 71f3301 Compare October 31, 2024 09:14
@marcosbento marcosbento marked this pull request as draft October 31, 2024 09:15
@wdeconinck
Copy link
Member

Hi @marcosbento thank you for taking up this issue! Could you add the test-code provided in #65 as well ?

- Add enabled/disabled features marker in project summary
- Force once enabled features to be displayed as enabled, regardless of
  of any disabled use

Re Github #65
@marcosbento marcosbento force-pushed the fix/better_print_summary_gh65 branch 2 times, most recently from 4bba4a4 to 8b5e8dd Compare November 5, 2024 16:13
@marcosbento marcosbento force-pushed the fix/better_print_summary_gh65 branch from 8b5e8dd to 662902f Compare November 5, 2024 16:18
@marcosbento marcosbento marked this pull request as ready for review November 5, 2024 18:42
Copy link
Member

@wdeconinck wdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I think it's good to merge.

@wdeconinck wdeconinck merged commit b6fc8a6 into develop Nov 8, 2024
19 checks passed
@marcosbento marcosbento deleted the fix/better_print_summary_gh65 branch November 11, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants