Add compiler flag override macro #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdeconinck
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Very nice separation of reusable functionality! Thanks @awnawab !
wdeconinck
force-pushed
the
feature/purge-compiler-flags
branch
from
c4acdc0 to
4be34fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in order to use per source file overridable flags, we have to run a cmake script before the call to project. This has the limitation that it limits the use of ecbuild_options in the compiler flags cmake script. The current PR removes this limitation by adding a new
ecbuild_override_compiler_flagsmacro that can be invoked after the call to project.