#30: Fix segfault from invalid pointer reference in grib_set_double_array() #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 28, 2020 20:47
This is to work around a bug when eccodes is used with numpy >= 1.17.4. Overwriting an existing numpy array variable with a FFI ctype object causes invalid pointer derefs, which results in a variety of bad outcomes, ranging from segfaults to invalid data. The workaround is simply to use a separate working variable to hold the numpy array in grib_set_double_array(), and avoid overwriting it with the ctype object. The workaround has been tested against the following numpy versions: - 1.17.3 - 1.17.4 - 1.17.5 - 1.18.0 - 1.19.0
|
Thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix a problem in grib_set_double_array() which can lead to a segfault against numpy versions from 1.17.4 onwards.
The segfault seems to occur due to using a numpy array's
ctypes.dataas the target for anffi.cast, and then immediately overwriting the numpy array with the results of the cast.The fix is simply to avoid overwriting the numpy array altogether, and keep the FFI ctype object in its own variable.