Skip to content

Commit

Permalink
Update ci.yml to fix notification
Browse files Browse the repository at this point in the history
The notify step was skipped on failing jobs because the `always()` was not handled properly. Instead of `always() && ${{ ... }}` we have to pull in the always `${{ always() && .. }}`
  • Loading branch information
geier1993 authored and shahramn committed Jun 7, 2024
1 parent 9cd97a7 commit fda9677
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ jobs:
- private-downstream-ci
- downstream-ci-hpc
- private-downstream-ci-hpc
if: always() && ${{ !github.event.pull_request.head.repo.fork && github.event.action != 'labeled' || github.event.label.name == 'approved-for-ci' }}
if: ${{ always() && !github.event.pull_request.head.repo.fork && github.event.action != 'labeled' || github.event.label.name == 'approved-for-ci' }}
steps:
- name: Trigger Teams notification
uses: ecmwf-actions/notify-teams@v1
Expand Down

0 comments on commit fda9677

Please sign in to comment.