Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with grid_second_order hanging when encoding fields with Infinite values #247

Closed

Conversation

pmarguinaud
Copy link
Contributor

@pmarguinaud pmarguinaud commented Oct 1, 2024

Enabling grid_second_order encoding does not fail when the field to encode contains Infinite values. Instead, it never terminates.

This PR :

  • adds a test to highlight the problem (commit a7f0abf)
  • adds a test in grib_scaling.cc to fix the issue (commit 3c38609); make the program abort when infinite (or nan) values are encountered

shahramn and others added 30 commits May 17, 2022 11:11
@shahramn
Copy link
Collaborator

shahramn commented Oct 2, 2024

Dear @pmarguinaud
Many thanks for your PR. But I noticed there are several changes (14 in total) but only a few related to the issue.
Can you please rebase your branch with the latest ecCodes "develop" branch?

@shahramn shahramn self-assigned this Oct 3, 2024
@shahramn shahramn requested a review from joobog October 3, 2024 08:31
@shahramn shahramn added the approved-for-ci Approved to run CI on ECMWF machines label Oct 3, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 74.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 87.80%. Comparing base (7f326c9) to head (3c38609).
Report is 29 commits behind head on develop.

Files with missing lines Patch % Lines
src/eccodes.cc 67.64% 11 Missing ⚠️
src/grib_scaling.cc 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #247      +/-   ##
===========================================
- Coverage    87.80%   87.80%   -0.01%     
===========================================
  Files          776      777       +1     
  Lines        62496    62512      +16     
  Branches     11035    11036       +1     
===========================================
+ Hits         54872    54886      +14     
- Misses        7624     7626       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahramn shahramn removed the request for review from joobog October 3, 2024 13:49
@shahramn shahramn removed the approved-for-ci Approved to run CI on ECMWF machines label Oct 3, 2024
@pmarguinaud pmarguinaud closed this Oct 4, 2024
@shahramn
Copy link
Collaborator

shahramn commented Oct 4, 2024

I have manually merged your changes. The next release of ecCodes (v2.39.0) will have it.
Many thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants