Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the overflow when calculating the limits of n-bit integers #249

Merged
merged 6 commits into from
Oct 9, 2024

Conversation

joobog
Copy link
Collaborator

@joobog joobog commented Oct 9, 2024

  • The min and max values of n-bit integers are calculated at compile-time and stored in a lookup-table.
  • A separate lookup-table is created for each data type.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.79%. Comparing base (7b40a63) to head (7b081ca).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #249   +/-   ##
========================================
  Coverage    87.79%   87.79%           
========================================
  Files          779      780    +1     
  Lines        62128    62131    +3     
  Branches     11050    11050           
========================================
+ Hits         54543    54546    +3     
  Misses        7585     7585           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahramn shahramn self-assigned this Oct 9, 2024
Copy link
Collaborator

@shahramn shahramn Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this new header file using an initial uppercase character in its name? none of our header files are like this

@shahramn shahramn merged commit f9cf293 into develop Oct 9, 2024
182 of 188 checks passed
@shahramn shahramn deleted the bugfix/ECC-1930_fix_overflow_in_numeric_limits branch October 9, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants