Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion of expressions and arguments to C++ #271

Merged
merged 17 commits into from
Dec 7, 2024

Conversation

joobog
Copy link
Collaborator

@joobog joobog commented Nov 19, 2024

@shahramn shahramn self-assigned this Nov 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 88.99549% with 195 lines in your changes missing coverage. Please review.

Project coverage is 87.75%. Comparing base (dd6bdb9) to head (7e8a006).

Files with missing lines Patch % Lines
src/expression/grib_expression_class_is_integer.cc 56.86% 22 Missing ⚠️
src/expression/grib_expression_class_is_in_dict.cc 76.38% 17 Missing ⚠️
src/expression/grib_expression.cc 20.00% 16 Missing ⚠️
src/expression/grib_expression_class_is_in_list.cc 81.17% 16 Missing ⚠️
src/expression/grib_expression_class_logical_or.cc 82.45% 10 Missing ⚠️
src/expression/grib_expression_class_accessor.cc 86.88% 8 Missing ⚠️
src/expression/grib_expression_class_length.cc 81.81% 8 Missing ⚠️
src/expression/grib_expression_class_sub_string.cc 73.33% 8 Missing ⚠️
src/expression/grib_expression_class_unop.cc 74.19% 8 Missing ⚠️
src/geo_nearest/grib_nearest_class_reduced.cc 63.63% 8 Missing ⚠️
... and 30 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #271      +/-   ##
===========================================
- Coverage    87.79%   87.75%   -0.04%     
===========================================
  Files          809      827      +18     
  Lines        62140    62050      -90     
  Branches     11039    11018      -21     
===========================================
- Hits         54558    54455     -103     
- Misses        7582     7595      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahramn shahramn added the approved-for-ci Approved to run CI on ECMWF machines label Dec 5, 2024
@shahramn shahramn merged commit 74c48a0 into develop Dec 7, 2024
182 checks passed
@shahramn shahramn deleted the feature/modernisation_expression branch December 7, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-for-ci Approved to run CI on ECMWF machines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants